feat(system): Filter system metadata by workspace and variable chaining #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit eb3a231 Author: Cameron Waterman <cameron.waterman@ni.com> Date: Thu Oct 5 09:19:51 2023 -0500 Address review feedback commit 723138e Author: Cameron Waterman <cameron.waterman@ni.com> Date: Wed Oct 4 11:05:24 2023 -0500 Remove unnecessary clearAllMocks commit ec5db21 Author: Cameron Waterman <cameron.waterman@ni.com> Date: Wed Oct 4 10:58:21 2023 -0500 feat(tag): Workspace variable resolution
cameronwaterman
commented
Oct 5, 2023
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
cameronwaterman
changed the title
mure
reviewed
Oct 5, 2023
|
It would be nice if we could not add the variable you're currently editing to the dropdown, but I'm not sure how to know that. |
Yeah I thought this as well, but wasn't having much luck actually getting the current variable name in the context of the variable query editor. I'll spend a bit more time looking into this today. |
cameronwaterman
commented
Oct 6, 2023
mure
approved these changes
Oct 6, 2023
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mure
pushed a commit
that referenced
this pull request
Oct 9, 2023
## [3.7.0](v3.6.0...v3.7.0) (2023-10-09) ### Features * **system:** Filter system metadata by workspace and variable chaining ([#43](#43)) ([14de6ed](14de6ed))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
https://ni.visualstudio.com/DevCentral/_workitems/edit/2527391
https://ni.visualstudio.com/DevCentral/_workitems/edit/2541892
👩💻 Implementation
metricFindQuery.🧪 Testing
Added tests and existing tests continue to pass.
✅ Checklist