Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-frame): Boolean and "Value" columns #46

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

cameronwaterman
Copy link
Collaborator

Pull Request

🀨 Rationale

https://ni.visualstudio.com/DevCentral/_workitems/edit/2553637
https://ni.visualstudio.com/DevCentral/_workitems/edit/2553643

πŸ‘©β€πŸ’» Implementation

  • For the boolean column issue, we're now converting the boolean stored in a string to it's proper type before converting to a data frame and transforming the rest of the values.
  • For the "Value" column issue, we're now just simply setting the column display name configuration to the column name.

πŸ§ͺ Testing

  • Verified fixes locally
  • Updated existing test

βœ… Checklist

@cameronwaterman cameronwaterman enabled auto-merge (squash) October 24, 2023 13:16
@cameronwaterman cameronwaterman merged commit 941dce3 into main Oct 24, 2023
1 check passed
mure pushed a commit that referenced this pull request Oct 24, 2023
## [3.7.3](v3.7.2...v3.7.3) (2023-10-24)

### Bug Fixes

* **data-frame:** Boolean and "Value" columns ([#46](#46)) ([941dce3](941dce3))
@mure
Copy link
Collaborator

mure commented Oct 24, 2023

πŸŽ‰ This PR is included in version 3.7.3 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Oct 24, 2023
@mure mure deleted the users/cwaterma/dataframe-datasource-fixes branch October 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants