Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataframe): visualize table properties #49

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

mure
Copy link
Collaborator

@mure mure commented Oct 31, 2023

Pull Request

🀨 Rationale

https://dev.azure.com/ni/DevCentral/_workitems/edit/2566752

πŸ‘©β€πŸ’» Implementation

  • Added a new field to the data frame query model, type. "Data" is the original behavior of the plugin and "Metadata" is a new mode that returns a table's properties as a data frame with two fields: name and value.
  • I did some refactoring while prototyping. The major things were:
    • Cleaned up the data conversion logic to not rely on the transform built in to Grafana (it didn't work for booleans and had an awkward API)
    • Added logic to the fake routes in the tests to better match what the actual service does. We were returning all of the columns of fake data in every test, which wasn't technically correct.

πŸ§ͺ Testing

  • Added a unit test for the metadata query

βœ… Checklist

@mure mure marked this pull request as ready for review November 1, 2023 14:43
@mure mure merged commit 8006749 into main Nov 1, 2023
1 check passed
@mure mure deleted the table-metadata-query branch November 1, 2023 22:09
mure pushed a commit that referenced this pull request Nov 1, 2023
## [3.8.0](v3.7.4...v3.8.0) (2023-11-01)

### Features

* **dataframe:** visualize table properties ([#49](#49)) ([8006749](8006749))
@mure
Copy link
Collaborator Author

mure commented Nov 1, 2023

πŸŽ‰ This PR is included in version 3.8.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants