Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataframe): Column variable support #50

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

cameronwaterman
Copy link
Collaborator

Pull Request

🀨 Rationale

https://ni.visualstudio.com/DevCentral/_workitems/edit/2566754

πŸ‘©β€πŸ’» Implementation

  • Added variable support to query editor columns field.
  • Added variable query editor to data frame data source that displays a table id field. This field also supports variables. Implemented metricFindQuery to return the selected tables columns.
  • Since the data frame query editor and variable query editor shared the majority of their logic, this was split out to a helper class that is accessed by both.

πŸ§ͺ Testing

  • Verified functionality locally
  • Added new tests and existing tests continue to pass

βœ… Checklist

@cameronwaterman
Copy link
Collaborator Author

@mure - This should be good to go again. The merge was pretty nasty so make sure you give it another look.

@cameronwaterman
Copy link
Collaborator Author

@mure - Submitting this since teams is showing you as OOO and so Josh can start playing with it. If you have responses to those two comments I can address them in a separate PR.

@cameronwaterman cameronwaterman merged commit db00fa6 into main Nov 3, 2023
1 check passed
@cameronwaterman cameronwaterman deleted the users/cwaterma/df-ds-variables branch November 3, 2023 16:08
mure pushed a commit that referenced this pull request Nov 3, 2023
## [3.9.0](v3.8.0...v3.9.0) (2023-11-03)

### Features

* **dataframe:** Column variable support ([#50](#50)) ([db00fa6](db00fa6))
@mure
Copy link
Collaborator

mure commented Nov 3, 2023

πŸŽ‰ This PR is included in version 3.9.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants