-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(system, data-frame): change term 'Metadata' to 'Properties' #83
base: main
Are you sure you want to change the base?
Conversation
@richie-ni Is this ready to be reviewed? I see that it's in the "Draft" state. |
@mure We wanted to get it reviewed internally, once done i will be moving the PR from the Draft state to Ready for review. |
@mure , @kkerezsi, @CiprianAnton , @cameronwaterman Could you please review the changes in the PR? |
@@ -1,7 +1,7 @@ | |||
import { DataQuery } from '@grafana/schema' | |||
|
|||
export enum SystemQueryType { | |||
Metadata = "Metadata", | |||
Properties = "Properties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a breaking change ... All widgets that are using Metadata are going to be broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming this is not a good solution .
cc @mure for awareness
🤨 Rationale
US : User Story 2861034: Update "Metadata" to "Properties" in the existing Grafana datasources - Systems and Dataframes
This Pull Request involves the change of updating the term 'MetaData' to 'Properties' as discussed in the Products & Results DataSource Requirements PR, in the Systems and DataFrame DataSource to improve clarity and consistency. This also involves renaming the
SystemMetadata
type toSystemProperties
across various files in the asset DataSource.👩💻 Implementation
SystemMetadata
toSystemProperties
in theQuerySystemsResponse
interface atsrc/core/types.ts
metadata
instead ofproperties
in all relevant filesSystemProperties
instead ofSystemMetadata
in all relevant files.'.🧪 Testing
✅ Checklist