Upgrade wgpu_svg example to latest version of usvg #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm is off again!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usvg has gone through some rather major API changes, and when trying to integrate code from your svg sample into a prototype I'm working on, I ran into some issues.
This upgrades the svg example to use the very latest usvg, 0.40.
It does not upgrade wgpu and winit and stuff, to keep PR complexity down.
Weirdly, throughout the course of the changes, sometimes the image would be offset by quite a bit, and then it would later come back. Some intricacy about hierachical transforms, I suspect. Oh well, it looks correct with test.svg in the latest commit, at least.