Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell): checks only the shell name and allows any argument #118

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

urecio
Copy link
Contributor

@urecio urecio commented Sep 25, 2023

Replace the bullet points below with your answers

Description

Switch statement checking check selection now checks only the shell's name.
This allows the user to still use one of the required shells, but pass any argument to it

Testing

No tests were added

@urecio
Copy link
Contributor Author

urecio commented Sep 25, 2023

Fixes #54

@nick-fields nick-fields self-requested a review September 26, 2023 13:23
@codecov-commenter
Copy link

Codecov Report

Merging #118 (a4d53cc) into master (1d41e5d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #118      +/-   ##
=========================================
- Coverage    2.54%   2.53%   -0.02%     
=========================================
  Files           3       3              
  Lines         157     158       +1     
  Branches       51      51              
=========================================
  Hits            4       4              
- Misses        140     141       +1     
  Partials       13      13              

Copy link
Owner

@nick-fields nick-fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @urecio!

:shipit:

@nick-fields nick-fields merged commit 1139f99 into nick-fields:master Sep 26, 2023
15 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants