Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Android dotcommands. #47

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Add support for Android dotcommands. #47

merged 7 commits into from
Aug 19, 2024

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Jun 27, 2024 •
edited
Loading

Description

This PR adds the support to run any of the adb, avdmanager, sdkmanager and emulator binary commands straight from a centralized CLI of mobile-helper. This can be achieved by running the following dot commands:

# Run adb command
npx @nightwatch/mobile-helper android.adb <ADB_ARGS>

# Run avdmanager command
npx @nightwatch/mobile-helper android.avdmanager <AVDMANAGER_ARGS>

# Run sdkmanager command
npx @nightwatch/mobile-helper android.sdkmanager <SDKMANAGER_ARGS>

# Run emulator command
npx @nightwatch/mobile-helper android.emulator <EMULATOR_ARGS>

Executing the command

image

Displaying usage instructions

image

garg3133
garg3133 reviewed Jul 3, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@garg3133
Copy link
Member

@itsspriyansh Can we get this ready now, whenever you find time?

@itsspriyansh
Copy link
Contributor Author

@garg3133 Absolutely!
I have updated and rebased the PR. Please take a look and let me know any suggestions.

garg3133
garg3133 reviewed Aug 17, 2024
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/commands/android/dotcommands.ts Outdated Show resolved Hide resolved
src/commands/android/dotcommands.ts Outdated Show resolved Hide resolved
@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated

@itsspriyansh
Copy link
Contributor Author

@garg3133 I have updated the PR.

@garg3133 garg3133 changed the title added class for dotcommands Add support for Android dotcommands. Aug 19, 2024
@garg3133 garg3133 merged commit 61711ef into nightwatchjs:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 garg3133 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsspriyansh @garg3133