Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show help for invalid subcommand #48

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Jul 3, 2024

Display help if an invalid subcommand is passed.

image

@garg3133
Copy link
Member

garg3133 commented Jul 5, 2024

Two things:

  • It's possible that the user didn't want to pass a subcommand and only passed it by mistake. To take that case into account as well, add the following line at the end: "For complete Android help, run: npx @nightwatch/mobile-helper android --help".
  • Replace [subcmd] in usage with just subcmd. [] blocks are used to represent optional arguments, but in the case of subcommands, passing the subcommand to use would not be optional.

@itsspriyansh
Copy link
Contributor Author

itsspriyansh commented Jul 6, 2024

@garg3133 Changes done and updated the preview image.

@itsspriyansh
Copy link
Contributor Author

@garg3133 Can we get this merged now?

src/commands/android/utils/common.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/index.ts Outdated Show resolved Hide resolved
@garg3133 garg3133 merged commit e84c677 into nightwatchjs:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants