feat: uninstall avd #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prerequisite #59 for adding the |
garg3133
reviewed
Aug 20, 2024
Comment on lines
19
to
21
| const installedAvds = execBinarySync(avdmanagerLocation, 'avdmanager', platform, 'list avd -c'); | ||
| if (!installedAvds) { | ||
| Logger.log(`${colors.yellow('Failed to fetch installed AVDs.')} Please try again.`); |
There was a problem hiding this comment.
We should also provide a command here that the user can run to list all the installed AVDs (probably using the dot command?).
Also, do you think it'd be worth adding a list subcommand to the tool, to list various things like list devices to list all the connected devices and list avd to list all the avds?
There was a problem hiding this comment.
Sounds like a good idea. We can add a subcommand for listing devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the support for deleting an AVD. This feature can be accessed with this command:
Screencast.from.02-08-24.11.59.10.AM.IST.webm