Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip_testcase_on_fail Does not skip the remaning test case on failure. #4254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ac-mmi
Copy link

@ac-mmi ac-mmi commented Aug 21, 2024

This pull request addresses issue #3939 with the skip_testcase_on_fail and abortOnFailure functionality in the Nightwatch.js library.

Changes:

  1. Added skip_testcase_on_fail flag initialization: The flag is now initialized in the AsyncTree constructor to properly handle test cases when this setting is enabled.
  2. Updated shouldSkipTestCaseOnFail method: Added a check to correctly handle skipping test cases based on the skip_testcase_on_fail flag and the error condition.
  3. Logging enhancements: Added logging to track the status of the skipRemainingTests flag during execution, making debugging easier.

These changes ensure that when skip_testcase_on_fail is set to true, subsequent test cases are skipped upon failure as expected, improving the consistency of test behavior.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants