-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supports mimalloc
for ARC/ORC (1.15x ~ 1.22x speedup booting the compiler)
#20359
Conversation
The first step is to check whether it reduces booting compilation time. I will refactor it later. Making it work comes first. |
It is weird that importing |
The booting time seems to drop at some extent by testing locally and on the CI ubuntu-20.04 (batch: 0_3) 15.347s => 12.546s (1.22x) |
mimalloc
for ARC/ORC (1.15x ~ 1.22x speedup booting the compiler)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still beneficial to support dynamic mimalloc, because if you have multiple Nim DLLs, or the main Nim program and other Nim modules as shared libraries, if each of them has their own copy of mimalloc, you won't be able to share GC'd objects between the instances. So, similar to how nimrtl has it, we can just allow users to use dynamic mimalloc
This comment was marked as resolved.
This comment was marked as resolved.
Not really, I add a new |
Waiting for #19972 |
This is critical for the v2.0 release btw. |
Sure. |
Closing for the time being as our allocator is also now threadsafe. |
Credits to @Yardanico
ref https://github.com/Yardanico/mimalloc_nim
I added the commit by
git commit --amend --author="Danil Yarantsev tiberiumk12@gmail.com" -m "supports mimalloc for ARC/ORC"