Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow definition of functions in global scope #7

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

shieldwed
Copy link
Member

Modules define functions in the global scope. This should not be marked as linter issue.

@shieldwed shieldwed self-assigned this Oct 5, 2023
@shieldwed shieldwed force-pushed the fix/allow_function_definition branch from 1ce05e5 to e9a66cf Compare October 5, 2023 15:18
Copy link

@oniet oniet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@shieldwed shieldwed force-pushed the fix/allow_function_definition branch from e9a66cf to 516d93c Compare October 5, 2023 15:39
@shieldwed shieldwed merged commit 2da4ed7 into master Oct 5, 2023
5 checks passed
@thde thde deleted the fix/allow_function_definition branch October 9, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants