-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Separate surfaces and morphometrics into standalone outputs #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. Assume you've tested? I'm not sure if this gets exercised by CI.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 54.07% 54.03% -0.05%
==========================================
Files 22 22
Lines 1459 1488 +29
Branches 206 209 +3
==========================================
+ Hits 789 804 +15
- Misses 614 628 +14
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Nope, though looks like it at least ran & completed in the circle tests. I'm using it for #358 so will test be tested there |
Tested locally 👍 |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
I'm okay with merging this, but you left it in draft state. Good to go? |
Rather than handling the paring down of surfaces when needed, this PR adds an aggregator node to collect and sort each surface output into a L/R list, simplifying retrieval for future use.