Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): deduplicate vendor and utils code #1054

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

yusdacra
Copy link
Member

@yusdacra yusdacra commented Oct 4, 2024

  • add a new rust-cargo-vendor module that is responsible for vendoring sources with cargo to deduplicate the vendoring across buildRustPackage and rust-crane
  • move utils.nix code that was duplicated in both rust builders to rust-cargo-lock and rust-cargo-vendor where it makes sense

@yusdacra yusdacra requested a review from DavHau October 4, 2024 03:29
@yusdacra yusdacra force-pushed the rust-refactor-vendor-utils branch from 4d03031 to f4dc2db Compare November 12, 2024 03:51
@yusdacra yusdacra merged commit 44d4141 into main Nov 12, 2024
4 checks passed
@yusdacra yusdacra deleted the rust-refactor-vendor-utils branch November 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant