Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geodesic Trace Function #15

Closed
wants to merge 2 commits into from
Closed

Conversation

zalo
Copy link
Contributor

@zalo zalo commented Jan 9, 2024

This PR exposes the Geodesic Trace Function, which I'm interested in using to wrap LED Strips around various shapes 😅

@nmwsharp
Copy link
Owner

Thanks! Happy to have this added :)

Is there any reason why you added it as a member of EdgeFlipSolver rather than a standalone function?

@zalo
Copy link
Contributor Author

zalo commented Jan 10, 2024

Ah, good shout; not sure why I thought it was in the same class of Algorithms; I'll break it out.

Also, while I have you here, is there a reasonable way to make a SurfacePoint from a cartesian point (via nearest-triangle/edge/vertex search)?

@nmwsharp
Copy link
Owner

Thank you for this! I adapted it in d1db3bb. New version will be coming soon. I made a few small changes, most importantly taking the direction as xyz world coordinates, since its not simple for users how to get tangent coordinates.

@nmwsharp nmwsharp closed this Jun 20, 2024
@nmwsharp
Copy link
Owner

P.S. I forgot to do it on that one, but I also added you as a coauthor on the next commit so you don't get robbed of showing up as a contributor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants