Add options for bypassing xfails and runs from configs. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
pushed a commit
that referenced
this pull request
Jul 18, 2024
These let you use options from config files but ignore xfail and skip run settings to easily get logs with all test failures, like these: * [pytest_compile_only_2024_03_21.txt](https://gist.github.com/ScottTodd/ecc9c57c01bfc5e996a15cdd38df6a9c) * [pytest_all_failures_2024_03_21.txt](https://gist.github.com/ScottTodd/1a02531cc76a3b8566428207e39d1870) Both of those are using `IREE compiler version 20240321.838 @ 5f2743baaa79160a3883854e60e5188822dceeb1` (This was previously possible by editing the config .json file, but now it's easier) So minimal repro instructions for latest nightly IREE ONNX test suite failures: ``` git clone https://github.com/nod-ai/SHARK-TestSuite.git cd SHARK-TestSuite python -m venv .venv source .venv/bin/activate python -m pip install -r iree_tests/requirements.txt python -m pip install --find-links https://iree.dev/pip-release-links.html iree-compiler iree-runtime --upgrade pytest iree_tests/onnx -n auto --ignore-xfails --config-files ./iree_tests/configs/config_cpu_llvm_sync.json ``` See the README for other common scenarios (like using a source build of IREE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These let you use options from config files but ignore xfail and skip run settings to easily get logs with all test failures, like these:
Both of those are using
IREE compiler version 20240321.838 @ 5f2743baaa79160a3883854e60e5188822dceeb1(This was previously possible by editing the config .json file, but now it's easier)
So minimal repro instructions for latest nightly IREE ONNX test suite failures:
See the README for other common scenarios (like using a source build of IREE)