Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] test TFIDF Vectorizer IDF and TFIDF modes #350

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ONNX] test TFIDF Vectorizer IDF and TFIDF modes #350

wants to merge 6 commits into from

Conversation

samutamm
Copy link

@samutamm samutamm commented Sep 24, 2024 •
edited
Loading

Add few end-to-end test cases for IDF and TFIDF modes of TFIDF Vectorizer.

Corresponding changes in torch-mlir: llvm/torch-mlir#3726

@samutamm samutamm marked this pull request as ready for review September 24, 2024 10:23
@marbre
Copy link
Contributor

marbre commented Sep 30, 2024

@zjgarvey could you do a second round?

@samutamm samutamm requested a review from zjgarvey October 1, 2024 19:37
@samutamm samutamm requested a review from marbre October 1, 2024 19:40
zjgarvey
zjgarvey approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the no-weights versions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

@marbre marbre Awaiting requested review from marbre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samutamm @marbre @zjgarvey