Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alt] remove default iree-compile extra args from onnx-iree mode #356

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[alt] remove default iree-compile extra args from onnx-iree mode #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e29ea68
Remove default iree-compile extra args from onnx-iree mode
zjgarvey Sep 30, 2024
00b59f6
Replace depreciated to deprecated
zjgarvey Oct 1, 2024
1edda54
Merge remote-tracking branch 'upstream/main' into iree-config-updates
zjgarvey Oct 25, 2024
ecab023
Revert to using target-backends flag. Don't modify user inputs.
zjgarvey Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 9 additions & 31 deletions alt_e2eshark/e2e_testing/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,36 +34,17 @@ class SimpleIREEBackend(BackendBase):
'''This backend uses iree to compile and run MLIR modules for a specified hal_target_backend'''
def __init__(self, *, device="local-task", hal_target_backend="llvm-cpu", extra_args : List[str] = None):
self.device = device
if hal_target_backend == "hip":
print("IREE compiler python bindings do not currently support the change to using iree-hal-target-device=hip. Defaulting to depreciated iree-hal-target-backends=rocm")
hal_target_backend = "rocm"
zjgarvey marked this conversation as resolved.
Show resolved Hide resolved
self.hal_target_backend = hal_target_backend
self.extra_args = []
if extra_args:
self.extra_args = []
for a in extra_args:
if a[0:2] == "--":
self.extra_args.append(a)
else:
self.extra_args.append("--" + a)
elif hal_target_backend == "rocm":
# some extra args for Mi300x - some of these may not work for other chips
self.extra_args = [
"--iree-rocm-target-chip=gfx942",
# "--iree-global-opt-propagate-transposes=true",
# "--iree-opt-outer-dim-concat=true",
# "--iree-opt-const-eval=false",
# "--iree-rocm-waves-per-eu=2",
# "--iree-llvmgpu-enable-prefetch",
# "--iree-flow-enable-aggressive-fusion",
# "--iree-flow-enable-fuse-horizontal-contractions=true",
# "--iree-opt-aggressively-propagate-transposes=true",
# "--iree-codegen-llvmgpu-use-vector-distribution=true",
# "--iree-preprocessing-pass-pipeline=builtin.module(util.func(iree-preprocessing-pad-to-intrinsics{pad-target-type=conv}))",
# maybe add iree-preprocessing-transpose-convolution-pipeline to preprocessing pipeline.
]
elif hal_target_backend == "llvm-cpu":
self.extra_args = [
"--iree-input-demote-i64-to-i32",
# "--iree-llvmcpu-fail-on-large-vector=0",
# "--iree-llvmcpu-stack-allocation-limit=300000",
]

def compile(self, module, *, save_to: str = None):
# compile to a vmfb for llvm-cpu
Expand Down Expand Up @@ -100,7 +81,10 @@ class CLIREEBackend(BackendBase):
'''This backend calls iree through the command line to compile and run MLIR modules'''
def __init__(self, *, device="local-task", hal_target_backend="llvm-cpu", extra_args : List[str] = None):
self.device = device
self.hal_target_backend = hal_target_backend
if hal_target_backend == "rocm":
print("Using 'iree-hal-target-device=hip', since 'iree-hal-target-backends' is depreciated")
hal_target_backend = "hip"
self.hal_target_device = hal_target_backend
self.extra_args = []
if extra_args:
for a in extra_args:
Expand All @@ -111,7 +95,7 @@ def __init__(self, *, device="local-task", hal_target_backend="llvm-cpu", extra_

def compile(self, module_path: str, *, save_to : str = None) -> str:
vmfb_path = os.path.join(save_to, "compiled_model.vmfb")
arg_string = f"--iree-hal-target-backends={self.hal_target_backend} "
arg_string = f"--iree-hal-target-device={self.hal_target_device} "
zjgarvey marked this conversation as resolved.
Show resolved Hide resolved
for arg in self.extra_args:
arg_string += arg
arg_string += " "
Expand Down Expand Up @@ -160,12 +144,6 @@ def __init__(self, *, device="local-task", hal_target_device="llvm-cpu", extra_a
self.extra_args = [
"--iree-hip-target=gfx90a",
]
elif hal_target_device == "llvm-cpu":
self.extra_args = [
"--iree-input-demote-i64-to-i32",
# "--iree-llvmcpu-fail-on-large-vector=0",
# "--iree-llvmcpu-stack-allocation-limit=300000",
]
self.providers = ["IreeExecutionProvider"]
# set provider options.
provider_options_dict = dict()
Expand Down
2 changes: 1 addition & 1 deletion alt_e2eshark/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def _get_argparse():
"--backend",
choices=["llvm-cpu", "amd-aie", "rocm", "hip", "cuda", "vmvx", "metal-spirv", "vulkan-spirv"],
default="llvm-cpu",
help="specifies the iree-hal-target-backend for compile phase",
help="specifies the iree-hal-target-device / iree-hal-target-backends for compile phase",
)
parser.add_argument(
"-ica",
Expand Down