Regenerate ONNX tests using newer torch-mlir. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Mar 1, 2024
There was a problem hiding this comment.
Note that we're down to 48 import failures now, compared to just 2 upstream in torch-mlir. The difference there comes from iree_tests/onnx/import_tests.py not handling all input and output protobufs from the ONNX test suite (e.g. sequence types, optional types). To support those (if we care), we'd need to write the conversion code from ONNX protos to .npy or .bin files. ONNX has helper functions here: https://github.com/onnx/onnx/blob/b48d763a2d22574540f51b6bc5ce1a537fb65024/onnx/backend/test/runner/__init__.py#L510-L523 but I wasn't quite sure how to get those saved to .npy files.
|
Ping? Want to review? (I can also just merge myself with no review :P) |
|
[AMD Official Use Only - General]
Sorry, could not get to it sooner. Will review by 11 am PST.
From: Scott Todd ***@***.***>
Sent: Monday, March 4, 2024 8:48 AM
To: nod-ai/SHARK-TestSuite ***@***.***>
Cc: Deepak, Kumar ***@***.***>; Review requested ***@***.***>
Subject: Re: [nod-ai/SHARK-TestSuite] Regenerate ONNX tests using newer torch-mlir. (PR #84)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Ping? Want to review? (I can also just merge myself with no review :P)
—
Reply to this email directly, view it on GitHub<#84 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5OMX32TVUUPMLMGRJYCKH3YWSQVFAVCNFSM6AAAAABECIXUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGAZDOOBVGM>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
|
kumardeepakamd
approved these changes
Mar 4, 2024
renxida
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Regenerate onnx tests using latest torch-mlir. * Update XFAIL lists in CPU and GPU Vulkan configs. * Rename config_cpu to config_cpu_llvm_sync matching IREE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
nonefor missing operands - these could be cleaned up with DCE/CSE/etc.)(Would be nice to put that version information in the repo / test case files somewhere...)
Unfortunately, none of the newly importable tests compile: