-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): Add ports mapping to Docker Compose example #1994
Conversation
Update docker-compose example with ports usage, because is better and more cofiable than expose usage
Maybe have both because they serve different purpose. |
Update readme.md include both method to expose the container.
@LaurentGoderre you are right. I added a new commit, what do you think? |
LGTM |
add a space Co-authored-by: Peter Dave Hello <hsu@peterdavehello.org>
Please allow me to clarify the PR title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@otaviosilva22 do you mind squashing the commits and updating the commit message(Maybe like the PR title)? Otherwise LGTM 👍
@LaurentGoderre, do you know how I can get a aprovall from a maintainer? |
@otaviosilva22 I think we can merge after the suggestions from @PeterDaveHello are in |
@LaurentGoderre, some checks were not successful. Run find . -name "*.md" | xargs -n 1 markdown-link-check -c markdown_link_check_config.json -q ERROR: 1 dead links found in ./README.md ! What do you suggest? |
Broken libc6-compat link fix.
@LaurentGoderre, I fixed libc6-compat link. What do you think? |
Co-authored-by: Peter Dave Hello <hsu@peterdavehello.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Update Docker Compose example with ports usage, because might be useful.
Description
Update Docker Compose example in readme.md with ports usage.
Motivation and Context
Ports might be useful to expose container to the host machine. This information is very important.
Testing Details
It's only readme.md update.
Example Output(if appropriate)
Types of changes
Checklist