Hide auto-generated files in code reviews and format Dockerfile templates #2062
Conversation
| /*/**/docker-entrypoint.sh linguist-generated | ||
| /Dockerfile*.template linguist-language=Dockerfile |
There was a problem hiding this comment.
The changes look great overall and will help reviewers focus on the essential parts of the code.
One minor thing: the last line change about .template files seems unrelated to the PR title and description. Perhaps we could tweak the commit message and PR title and description slightly to fully encompass this change as well.
Other than that, I have no concerns. Let me know what you think!
There was a problem hiding this comment.
A second thought: sometimes, we may still check the generated files to ensure effective changes. Would that be affected if we want to do so? Like, be difficult?
There was a problem hiding this comment.
It just hides it by default but you can still reveal it (a bit like a file that has too many diff). This would be helpful for bot generated PR.
|
The description is missing, but I think I saw some comment on the other tread. If this auto-collapses the files in the review tab, I'm -0. Yes, they are generated, but we need to check that things like the hashes aren't missing, or if someone isn't manually making a change. |
LaurentGoderre
changed the title
No description provided.