-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node.js 22.0.0 #2071
feat: Node.js 22.0.0 #2071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the wrong version is generated?
the alpine build also hasn't started building yet, from what I can see
Thanks for doing this! It looks like you already caught the |
How long does this usually take? |
Sometimes an hour or so, but I think it ran into a problem, so I opened nodejs/unofficial-builds#141 |
Musl builds are there now, so please update the PR 🙂 |
6a392a8
to
aedf364
Compare
Squashed and pushed up the changes! |
The checksum is wrong? Did you use the update script to poll it? Running it gives me this diff diff --git i/22/alpine3.18/Dockerfile w/22/alpine3.18/Dockerfile
index cec5d46..21fddbb 100644
--- i/22/alpine3.18/Dockerfile
+++ w/22/alpine3.18/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
curl \
&& ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
&& case "${alpineArch##*-}" in \
- x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+ x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
x86) OPENSSL_ARCH=linux-elf;; \
aarch64) OPENSSL_ARCH=linux-aarch64;; \
arm*) OPENSSL_ARCH=linux-armv4;; \
diff --git i/22/alpine3.19/Dockerfile w/22/alpine3.19/Dockerfile
index 6900e91..d79a458 100644
--- i/22/alpine3.19/Dockerfile
+++ w/22/alpine3.19/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
curl \
&& ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
&& case "${alpineArch##*-}" in \
- x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+ x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
x86) OPENSSL_ARCH=linux-elf;; \
aarch64) OPENSSL_ARCH=linux-aarch64;; \
arm*) OPENSSL_ARCH=linux-armv4;; \ |
aedf364
to
ff8907a
Compare
I had updated the checksums based on what was provided in https://nodejs.org/en/blog/release/v22.0.0 - but I see now the value provided in the script is different - updated! |
Alpine shasums are from https://unofficial-builds.nodejs.org/download/release/v22.0.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Created PR on the official-images repo (docker-library/official-images#16663). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Description
Release for Node.js 22.0.0: https://nodejs.org/en/blog/release/v22.0.0
Based on #1882 and #1980
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist