Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Node.js 22.0.0 #2071

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: Node.js 22.0.0 #2071

merged 1 commit into from
Apr 25, 2024

Conversation

AbhiPrasad
Copy link
Contributor

@AbhiPrasad AbhiPrasad commented Apr 24, 2024

Description

Release for Node.js 22.0.0: https://nodejs.org/en/blog/release/v22.0.0

Based on #1882 and #1980

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the wrong version is generated?

the alpine build also hasn't started building yet, from what I can see

22/alpine3.18/Dockerfile Outdated Show resolved Hide resolved
@nschonni
Copy link
Member

Thanks for doing this! It looks like you already caught the chmod for the scripts too.
Once the the Alpine images are available in https://unofficial-builds.nodejs.org/download/release/v22.0.0/, please re-update this and squash it down to a single commit

@AbhiPrasad
Copy link
Contributor Author

Once the the Alpine images are available

How long does this usually take?

@nschonni
Copy link
Member

Sometimes an hour or so, but I think it ran into a problem, so I opened nodejs/unofficial-builds#141

@SimenB
Copy link
Member

SimenB commented Apr 25, 2024

Musl builds are there now, so please update the PR 🙂

@AbhiPrasad AbhiPrasad force-pushed the node-22-docker-file branch from 6a392a8 to aedf364 Compare April 25, 2024 13:06
@AbhiPrasad
Copy link
Contributor Author

Squashed and pushed up the changes!

@AbhiPrasad AbhiPrasad requested a review from SimenB April 25, 2024 13:11
@SimenB
Copy link
Member

SimenB commented Apr 25, 2024

The checksum is wrong? Did you use the update script to poll it? Running it gives me this diff

diff --git i/22/alpine3.18/Dockerfile w/22/alpine3.18/Dockerfile
index cec5d46..21fddbb 100644
--- i/22/alpine3.18/Dockerfile
+++ w/22/alpine3.18/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
         curl \
     && ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
       && case "${alpineArch##*-}" in \
-        x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+        x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
         x86) OPENSSL_ARCH=linux-elf;; \
         aarch64) OPENSSL_ARCH=linux-aarch64;; \
         arm*) OPENSSL_ARCH=linux-armv4;; \
diff --git i/22/alpine3.19/Dockerfile w/22/alpine3.19/Dockerfile
index 6900e91..d79a458 100644
--- i/22/alpine3.19/Dockerfile
+++ w/22/alpine3.19/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
         curl \
     && ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
       && case "${alpineArch##*-}" in \
-        x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+        x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
         x86) OPENSSL_ARCH=linux-elf;; \
         aarch64) OPENSSL_ARCH=linux-aarch64;; \
         arm*) OPENSSL_ARCH=linux-armv4;; \

@AbhiPrasad AbhiPrasad force-pushed the node-22-docker-file branch from aedf364 to ff8907a Compare April 25, 2024 14:35
@AbhiPrasad
Copy link
Contributor Author

I had updated the checksums based on what was provided in https://nodejs.org/en/blog/release/v22.0.0 - but I see now the value provided in the script is different - updated!

@SimenB
Copy link
Member

SimenB commented Apr 25, 2024

Alpine shasums are from https://unofficial-builds.nodejs.org/download/release/v22.0.0/

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 9b2eb0d into nodejs:main Apr 25, 2024
17 checks passed
Copy link

Created PR on the official-images repo (docker-library/official-images#16663). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@AbhiPrasad AbhiPrasad deleted the node-22-docker-file branch April 25, 2024 14:49
@jnoordsij jnoordsij mentioned this pull request Oct 16, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants