Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add FAQ to releases section #55992

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: add FAQ to releases section #55992

wants to merge 2 commits into from
+36 −0

Conversation

RafaelGSS
Copy link
Member

After a short discussion on the releasers channel, I thought it wouldn't hurt to open this PR to see what the team feels about it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 25, 2024
@RafaelGSS RafaelGSS requested a review from a team November 25, 2024 14:56
ruyadorno
ruyadorno approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! ❤️

we could potentially want to have answers be collapsed in the future in case they reach a critical mass but while it's under a dozen or so I think this is going to work great.

@RafaelGSS @aduh95
Apply suggestions from code review
0bb2fc4 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 26, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RafaelGSS @nodejs-github-bot @ruyadorno @lpinca @richardlau @aduh95