fetch: add docs on why forbidden header names are not supported #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Uzlopak
requested changes
Oct 7, 2024
|
I find the comments harder to read considering it merges two different spec functions (I understand they're out of date). I don't see any value in documenting why we don't implement forbidden headers either as it's well-known and documented already. |
|
The benefit is for developers who read the code on while going through the implementation. |
|
Why do we deviate from the spec?
|
|
The source code is for https://fetch.spec.whatwg.org/#concept-headers-append The screenshot provided is for https://fetch.spec.whatwg.org/#headers-class |
KhafraDev
requested changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Changes
Documents why undici fetch does not support forbidden header names
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status