Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Read user_config by path #3257

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mk-pmb
Copy link
Contributor

@mk-pmb mk-pmb commented Aug 29, 2020

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

Disclosing the true path allows for relative includes in user_config.

Disclosing the true path allows for relative includes in user_config.
@TerryE
Copy link
Collaborator

TerryE commented Aug 29, 2020

As I said in the issue, I don't really want to dick around with something that we want to remove.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@mk-pmb
Copy link
Contributor Author

mk-pmb commented Apr 16, 2022

Will the removal happen soon? Otherwise, let's help people deal with the status quo until we can really remove it.

@stale stale bot removed the stale label Apr 16, 2022
@HHHartmann
Copy link
Member

The relevant issue would be #1223? How could I include my own configs after this PR?
As I would not only have my own user_config but also user_modules and user_version would this PR suffice for that too?

@mk-pmb
Copy link
Contributor Author

mk-pmb commented Apr 17, 2022

The relevant issue would be …?

I don't know if that issue is related in any way.
The issue I had, and caused me to write this patch, does not have a thread, as to me it didn't seem worth explaining. In my opinion, the opposite would be true: The current approach of concealing the filename would need a justification, and thus, documentation.

How could I include my own configs after this PR?

I expect that all previous workflows continue to work. That is, I hope no-one has relied on using relative file paths in their config in the current scenario where these paths would be calculated based on an expressly concealed origin.

As I would not only have my own user_config but also user_modules and user_version would this PR suffice for that too?

I don't understand the question, sorry.
Easiest way to check would probably be to temporarily patch this into your local repo and retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants