Matrix keyboard module #3631
Matrix keyboard module #3631
Conversation
| int character = -1; | ||
|
|
||
| // We are either waiting for a negative edge (keypress) or a positive edge | ||
| // (keyrelease) |
There was a problem hiding this comment.
This comment is confusing me - we just disabled row interrupts, so why would we be waiting for an edge?
| QUEUE_IT(d, character); | ||
| if (!d->task_queued) { | ||
| if (task_post_medium(tasknumber, (task_param_t)d)) { | ||
| d->task_queued = 1; |
There was a problem hiding this comment.
I believe d->task_queued needs to be mutex protected, as it gets written by both the GPIO ISR/task as well as the NodeMCU task.
| if (*cb_ptr != LUA_NOREF) { | ||
| luaL_unref(L, LUA_REGISTRYINDEX, *cb_ptr); | ||
| *cb_ptr = LUA_NOREF; | ||
| } |
There was a problem hiding this comment.
This would be neater with luaL_unref2() instead.
|
|
||
| typedef struct { | ||
| int32_t character; // 1 + character for press, -1 - character for release | ||
| uint32_t time_us; |
There was a problem hiding this comment.
This field never appears to be filled in, but is used in the callback.
|
|
||
| if (!HAS_QUEUED_DATA(d)) { | ||
| luaL_unref(L, LUA_REGISTRYINDEX, d->self_ref); | ||
| } |
There was a problem hiding this comment.
I'd be tempted to change this to a task_post so we only have a single place where we release the self_ref, for easier reasoning.
| callback_free(L, d, MATRIX_ALL); | ||
|
|
||
| if (matrix_close( d )) { | ||
| return luaL_error( L, "Unable to close switch." ); |
| @@ -0,0 +1,77 @@ | |||
| # matrix Module | |||
There was a problem hiding this comment.
Would a better name be matrixkdb even? There are many types of matrices, I mean.
|
Ah, one other review comment - the documentation needs to be linked in |
Fixes #3630
devbranch rather than for thereleasebranch.docs/*.This adds the
matrixmodule which supports simple matrix keypads. Simple interface -- it just calls a specified callback on key press (and/or key release).