fix(npm): fetching npm versions not working #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn’t the semver package handle version breakdowns? The regular expression could be redundant to that. |
|
As described in the comment the npm/cli repository also has many releases of other libraries which are not npm, so the version regex is used to filter out these libraries -> https://github.com/npm/cli/releases The problem with the former fix was that it is no object but just the version names returned by the previous function. The unfiltered cli array looks like that: |
marcelklehr
approved these changes
Dec 9, 2023
| assert.ifError(error); | ||
| debug('listVersions: ' + result); | ||
| assert.ok(Array.isArray(result)); | ||
| result.forEach((version) => assert.match(version, versionRegex)); | ||
| } |
There was a problem hiding this comment.
Great to have a test for this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly a change that I was unaware of broke the installation of npm versions, fixed that and prepared a new version.