-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: avoid unnecessary re-renders #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummarybenchmark-total
Resultsemoji-picker-element-change-tab
emoji-picker-element-database-interactions
emoji-picker-element-first-load
emoji-picker-element-search
emoji-picker-element-second-load
|
Size Change: +57 B (+0.16%) Total Size: 36.4 kB
|
nolanlawson
force-pushed
the
no-rerender
branch
from
August 16, 2024 00:21
3a67dab
to
57e1937
Compare
Had to bump up the CPU throttling to 20 and reduce auto sample condition to 1% to see the impact, but it is an improvement: Click to see
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment where we avoid additional re-renders by 1) not forcing an update to the
state
is object equality is still the same, and 2) avoiding an extra re-render if the browser supports all ZWJ-containing emoji.Probably needs a battery of tests before it can be merged, but opening the PR anyway.