Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run benchmarks in non-PERF mode #440

Merged
merged 1 commit into from
Aug 16, 2024
Merged

chore: run benchmarks in non-PERF mode #440

merged 1 commit into from
Aug 16, 2024

Conversation

nolanlawson
Copy link
Owner

Follow-up to #439

Unfortunately, since I can't figure out how to get PERF=1 mode running when Tachometer builds the remote branch, we should just disable it everywhere. It gives additional instrumentation, which may distort the benchmark since we're not technically comparing apples to apples. The downside is that it's harder to debug the benchmarks, but it's better to have accurate benchmarks than debuggable ones (for now).

Copy link

github-actions bot commented Aug 16, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -1% - +1% (-0.38ms - +0.35ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +2% (-4.33ms - +2.24ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -2% - +5% (-1.06ms - +2.56ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -3% - +5% (-1.45ms - +2.12ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.89ms - 34.49ms-unsure 🔍
-1% - +1%
-0.38ms - +0.35ms
tip-of-tree
tip-of-tree
33.99ms - 34.41msunsure 🔍
-1% - +1%
-0.35ms - +0.38ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
97.18ms - 101.55ms-unsure 🔍
-4% - +2%
-4.33ms - +2.24ms
tip-of-tree
tip-of-tree
97.96ms - 102.87msunsure 🔍
-2% - +4%
-2.24ms - +4.33ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.87ms - 54.06ms-unsure 🔍
-2% - +5%
-1.06ms - +2.56ms
tip-of-tree
tip-of-tree
50.78ms - 53.66msunsure 🔍
-5% - +2%
-2.56ms - +1.06ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
44.03ms - 46.78ms-unsure 🔍
-3% - +5%
-1.45ms - +2.12ms
tip-of-tree
tip-of-tree
43.94ms - 46.20msunsure 🔍
-5% - +3%
-2.12ms - +1.45ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: 0 B

Total Size: 36.3 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 36.3 kB

compressed-size-action

@nolanlawson nolanlawson merged commit a14ffb7 into master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant