Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not render offscreen pseudo at all #457

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

nolanlawson
Copy link
Owner

Might be a perf improvement, let's see.

Copy link

github-actions bot commented Sep 14, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -6% - +6% (-2.20ms - +2.26ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -7% - +3% (-8.04ms - +3.13ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -8% - +2% (-4.32ms - +1.29ms)
    this-change vs tip-of-tree
  • emoji-picker-element-many-custom-emoji: unsure 🔍 -5% - +7% (-7.31ms - +9.92ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: faster ✔ 3% - 9% (1.36ms - 4.09ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.78ms - 37.74ms-unsure 🔍
-6% - +6%
-2.20ms - +2.26ms
tip-of-tree
tip-of-tree
34.57ms - 37.90msunsure 🔍
-6% - +6%
-2.26ms - +2.20ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
107.55ms - 114.97ms-unsure 🔍
-7% - +3%
-8.04ms - +3.13ms
tip-of-tree
tip-of-tree
109.53ms - 117.89msunsure 🔍
-3% - +7%
-3.13ms - +8.04ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.62ms - 55.74ms-unsure 🔍
-8% - +2%
-4.32ms - +1.29ms
tip-of-tree
tip-of-tree
53.30ms - 57.10msunsure 🔍
-2% - +8%
-1.29ms - +4.32ms
-
emoji-picker-element-many-custom-emoji
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
136.20ms - 148.52ms-unsure 🔍
-5% - +7%
-7.31ms - +9.92ms
tip-of-tree
tip-of-tree
135.03ms - 147.07msunsure 🔍
-7% - +5%
-9.92ms - +7.31ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.66ms - 44.23ms-faster ✔
3% - 9%
1.36ms - 4.09ms
tip-of-tree
tip-of-tree
45.05ms - 47.28msslower ❌
3% - 9%
1.36ms - 4.09ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: -43 B (-0.12%)

Total Size: 37.3 kB

Filename Size Change
./bundle.js 37.3 kB -43 B (-0.12%)

compressed-size-action

@nolanlawson
Copy link
Owner Author

No change in Chrome, but it is a change in Firefox:

┌─────────────┬─────────────────┐
│     Browser │ chrome-headless │
│             │ 128.0.0.0       │
├─────────────┼─────────────────┤
│ Sample size │ 1360            │
└─────────────┴─────────────────┘

┌─────────────┬─────────────┬─────────────┬─────────────────────┬───────────────────┬───────────────────┐
│ Benchmark   │ Version     │ Bytes       │            Avg time │    vs this-change │    vs tip-of-tree │
│             │             │             │                     │                   │       tip-of-tree │
├─────────────┼─────────────┼─────────────┼─────────────────────┼───────────────────┼───────────────────┤
│ this-change │ <none>      │ 1026.74 KiB │ 118.29ms - 121.70ms │                   │            unsure │
│             │             │             │                     │          -        │         -2% - +2% │
│             │             │             │                     │                   │ -3.00ms - +2.10ms │
├─────────────┼─────────────┼─────────────┼─────────────────────┼───────────────────┼───────────────────┤
│ tip-of-tree │ tip-of-tree │ 1026.78 KiB │ 118.54ms - 122.34ms │            unsure │                   │
│             │             │             │                     │         -2% - +3% │          -        │
│             │             │             │                     │ -2.10ms - +3.00ms │                   │
└─────────────┴─────────────┴─────────────┴─────────────────────┴───────────────────┴───────────────────┘


┌─────────────┬──────────────────┐
│     Browser │ firefox-headless │
│             │ 129.0            │
├─────────────┼──────────────────┤
│ Sample size │ 700              │
└─────────────┴──────────────────┘

┌─────────────┬─────────────┬─────────────┬─────────────────────┬─────────────────┬─────────────────┐
│ Benchmark   │ Version     │ Bytes       │            Avg time │  vs this-change │  vs tip-of-tree │
│             │             │             │                     │                 │     tip-of-tree │
├─────────────┼─────────────┼─────────────┼─────────────────────┼─────────────────┼─────────────────┤
│ this-change │ <none>      │ 1026.74 KiB │ 131.38ms - 133.35ms │                 │          faster │
│             │             │             │                     │        -        │         1% - 3% │
│             │             │             │                     │                 │ 1.34ms - 4.15ms │
├─────────────┼─────────────┼─────────────┼─────────────────────┼─────────────────┼─────────────────┤
│ tip-of-tree │ tip-of-tree │ 1026.78 KiB │ 134.11ms - 136.11ms │          slower │                 │
│             │             │             │                     │         1% - 3% │        -        │
│             │             │             │                     │ 1.34ms - 4.15ms │                 │
└─────────────┴─────────────┴─────────────┴─────────────────────┴─────────────────┴─────────────────┘

@nolanlawson nolanlawson merged commit 47d93f2 into master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant