perf: optimize setting attributes

[nolanlawson]

Very slight pref optimization, adds some complexity, but may be worth the tradeoff. Also avoids rendering useless empty attributes like aria-selected=''.

[github-actions]

📊 Tachometer Benchmark Results

Summary

benchmark-total

• emoji-picker-element-change-tab: unsure 🔍 -7% - +4% (-2.49ms - +1.40ms)
  ^{this-change vs tip-of-tree}
• emoji-picker-element-database-interactions: unsure 🔍 -3% - +4% (-3.54ms - +4.07ms)
  ^{this-change vs tip-of-tree}
• emoji-picker-element-first-load: unsure 🔍 -3% - +6% (-1.66ms - +2.95ms)
  ^{this-change vs tip-of-tree}
• emoji-picker-element-many-custom-emoji: unsure 🔍 -9% - +2% (-13.18ms - +3.21ms)
  ^{this-change vs tip-of-tree}
• emoji-picker-element-search: unsure 🔍 -7% - +4% (-3.13ms - +1.64ms)
  ^{this-change vs tip-of-tree}
• emoji-picker-element-second-load: unsure 🔍 -4% - +4% (-1.74ms - +1.82ms)
  ^{this-change vs tip-of-tree}

Results

emoji-picker-element-change-tab

• Browser: chrome-headless 128.0.0.0
• Sample size: 50
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	34.50ms - 37.08ms	-	unsure 🔍 -7% - +4% -2.49ms - +1.40ms
tip-of-tree tip-of-tree	34.88ms - 37.79ms	unsure 🔍 -4% - +7% -1.40ms - +2.49ms	-

emoji-picker-element-database-interactions

• Browser: chrome-headless 128.0.0.0
• Sample size: 50
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	106.46ms - 112.11ms	-	unsure 🔍 -3% - +4% -3.54ms - +4.07ms
tip-of-tree tip-of-tree	106.47ms - 111.57ms	unsure 🔍 -4% - +3% -4.07ms - +3.54ms	-

emoji-picker-element-first-load

• Browser: chrome-headless 128.0.0.0
• Sample size: 50
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	52.11ms - 55.37ms	-	unsure 🔍 -3% - +6% -1.66ms - +2.95ms
tip-of-tree tip-of-tree	51.47ms - 54.73ms	unsure 🔍 -5% - +3% -2.95ms - +1.66ms	-

emoji-picker-element-many-custom-emoji

• Browser: chrome-headless 128.0.0.0
• Sample size: 60
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	127.77ms - 139.22ms	-	unsure 🔍 -9% - +2% -13.18ms - +3.21ms
tip-of-tree tip-of-tree	132.61ms - 144.35ms	unsure 🔍 -3% - +10% -3.21ms - +13.18ms	-

emoji-picker-element-search

• Browser: chrome-headless 128.0.0.0
• Sample size: 50
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	42.65ms - 45.80ms	-	unsure 🔍 -7% - +4% -3.13ms - +1.64ms
tip-of-tree tip-of-tree	43.18ms - 46.75ms	unsure 🔍 -4% - +7% -1.64ms - +3.13ms	-

emoji-picker-element-second-load

• Browser: chrome-headless 128.0.0.0
• Sample size: 50
• Built by: Benchmarks #500

• Commit: 3d459a6

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	43.73ms - 46.05ms	-	unsure 🔍 -4% - +4% -1.74ms - +1.82ms
tip-of-tree tip-of-tree	43.49ms - 46.20ms	unsure 🔍 -4% - +4% -1.82ms - +1.74ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions]

Size Change: +154 B (+0.41%)

Total Size: 37.6 kB

Filename	Size	Change
./bundle.js	37.6 kB	+154 B (+0.41%)

_{compressed-size-action}

[nolanlawson]

The perf improvement is ~1% and the added complexity is high, so nah