Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid undefined/null expression values #461

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: avoid undefined/null expression values #461

merged 2 commits into from
Sep 20, 2024

Conversation

nolanlawson
Copy link
Owner

@nolanlawson nolanlawson commented Sep 20, 2024

We could accidentally render the string undefined in some cases which would be wrong. Might as well guard against it.

Copy link

github-actions bot commented Sep 20, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +5% (-0.94ms - +1.67ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -8% - +3% (-9.56ms - +3.59ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -8% - +2% (-4.26ms - +1.02ms)
    this-change vs tip-of-tree
  • emoji-picker-element-many-custom-emoji: unsure 🔍 -6% - +8% (-7.71ms - +10.49ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -4% - +2% (-1.75ms - +1.00ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.08ms - 36.05ms-unsure 🔍
-3% - +5%
-0.94ms - +1.67ms
tip-of-tree
tip-of-tree
33.85ms - 35.55msunsure 🔍
-5% - +3%
-1.67ms - +0.94ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
107.29ms - 115.79ms-unsure 🔍
-8% - +3%
-9.56ms - +3.59ms
tip-of-tree
tip-of-tree
109.51ms - 119.54msunsure 🔍
-3% - +9%
-3.59ms - +9.56ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.86ms - 54.37ms-unsure 🔍
-8% - +2%
-4.26ms - +1.02ms
tip-of-tree
tip-of-tree
52.27ms - 56.21msunsure 🔍
-2% - +8%
-1.02ms - +4.26ms
-
emoji-picker-element-many-custom-emoji
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
135.11ms - 147.94ms-unsure 🔍
-6% - +8%
-7.71ms - +10.49ms
tip-of-tree
tip-of-tree
133.68ms - 146.58msunsure 🔍
-7% - +5%
-10.49ms - +7.71ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
43.16ms - 44.94ms-unsure 🔍
-4% - +2%
-1.75ms - +1.00ms
tip-of-tree
tip-of-tree
43.38ms - 45.48msunsure 🔍
-2% - +4%
-1.00ms - +1.75ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: +12 B (+0.03%)

Total Size: 37.4 kB

Filename Size Change
./bundle.js 37.4 kB +12 B (+0.03%)

compressed-size-action

@nolanlawson nolanlawson merged commit 5eb642a into master Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant