Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Calico metrics, fix relabeling rule. #9

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Improve Calico metrics, fix relabeling rule. #9

merged 1 commit into from
Mar 26, 2024

Conversation

fasaxc
Copy link
Contributor

@fasaxc fasaxc commented Mar 15, 2024

Adjust Calico metrics:

  • Collect metrics from either kube-system or calico-system namespaces. The namespace depends on how Calico was installed.
  • Fix Prometheus node relabeling rule. It was creating one target per node but all the targets used localhost for the address!

mazdakn
mazdakn approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mazdakn mazdakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We also need to update the gradana_dash.json file to use the new metric.

@npinaeva npinaeva merged commit e498c18 into npinaeva:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazdakn mazdakn mazdakn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fasaxc @mazdakn @npinaeva