Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project details preview #1957

Merged
merged 28 commits into from
Jan 12, 2024
Merged

feat: add project details preview #1957

merged 28 commits into from
Jan 12, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Dec 12, 2023

Overview Loom:
https://www.loom.com/share/ca760ca060574f6aac84370ed6cd0e6a

This PR does a couple of things:

  • rework the graph integration to use a NxGraphServer & static html from node_modules
    • the graph server will spin up an instance of nx graph --watch in the background
    • jetbrains jcef browser loads info directly from the local server
    • vscode webview loads info by passing messages through the vscode api
  • add project details view
    • based on the same graph logic
    • split editor for intellij, open to side action for vscode
  • a bunch of refactorings on the way, moving stuff around, updates, etc

Copy link

nx-cloud bot commented Dec 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d51823. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress


Sent with 💌 from NxCloud.

@MaxKless MaxKless requested a review from Cammisuli December 12, 2023 14:44
Copy link

nx-cloud bot commented Dec 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd5ad32. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@MaxKless MaxKless marked this pull request as draft December 18, 2023 10:01
@MaxKless MaxKless marked this pull request as ready for review January 12, 2024 08:24
@MaxKless MaxKless merged commit 0ded9b2 into master Jan 12, 2024
7 checks passed
@MaxKless MaxKless deleted the project-details branch January 12, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants