Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): improve codelens if no targets exist for project #2303

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Nov 4, 2024

Before, when there were no targets for a project, we showed this awkward empty codelens. It opens a quickpick with only one action:
image

Now we directly show the Open Project Details action:
image

This will be complemented by an improvement to the PDV to show a better empty state in the PDV with links to documentation.

In case you're wondering, it's not possible to just not show a codelens at this point. The codelens is already created (by parsing the json file, has to be quick). Whether there's a target on this project can only be known later in this async project-graph-dependent resolution of the codelens content.

Copy link

nx-cloud bot commented Nov 4, 2024

@MaxKless MaxKless merged commit 9183dce into master Nov 5, 2024
5 checks passed
@MaxKless MaxKless deleted the codelens-empty-state branch November 5, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants