Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): retry nxls request if connection is disposed during request #2312

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Nov 12, 2024

Right now, if a request takes longer and users try to refresh the language server while the request is in flight (actually passed along to the language client, not just in our wrapper), an error will be thrown.
This is potentially very ugly if run from a command and can be avoided.
With our new state machine architecture, we can simply retry the request since it will automatically wait for the client to be running.

Copy link

nx-cloud bot commented Nov 12, 2024

@MaxKless MaxKless merged commit 6709217 into master Nov 12, 2024
5 checks passed
@MaxKless MaxKless deleted the retry-request-on-connection-disposed branch November 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants