refactor: use project graph data structure directly #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b99dbdb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
MaxKless
force-pushed
the
use-project-graph-directly
branch
2 times, most recently
from
a8577a3 to
d3e5eff
Compare
Coly010
approved these changes
Nov 27, 2024
| return nxWorkspace.projectGraph | ||
| ?.nodes | ||
| ?.values | ||
| ?.flatMap { p -> p.data.targets.keys.map { it to p.name } } |
There was a problem hiding this comment.
I assume this handles if data and targets is null?
| return nxWorkspace.workspace.projects | ||
| .filter { it.value.targets.contains(targetsListNode.targetName) } | ||
| return nxWorkspace.projectGraph.nodes | ||
| .filter { it.value.data.targets.contains(targetsListNode.targetName) } |
| ?.entries | ||
| ?.map { entry -> entry.key to (entry.value.targets.keys) } | ||
| ?.map { entry -> entry.key to (entry.value.data.targets.keys) } |
libs/shared/utils/src/lib/utils.ts
Outdated
| w.projects = Object.fromEntries(sortedProjects); | ||
| return w; | ||
| } | ||
| // export function sortWorkspaceProjects( |
There was a problem hiding this comment.
Can this commenter section be removed?
MaxKless
force-pushed
the
use-project-graph-directly
branch
from
d3e5eff to
66c8285
Compare
MaxKless
force-pushed
the
use-project-graph-directly
branch
from
80e3bbd to
b99dbdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.