feat(nxls): decouple daemon lifecycle from nxls lifecycle #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MaxKless
commented
Dec 3, 2024
MaxKless
commented
- log enabled
- changes
- start daemon separately & dont kill on shutdown
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b97a01d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
daemon-startup-decoupling
branch
from
3b86f71 to
b97a01d
Compare
jaysoo
reviewed
Dec 6, 2024
| @@ -134,6 +137,14 @@ export class NxlsWrapper { | |||
|
|
|||
| this.process?.removeListener('exit', this.earlyExitListener); | |||
|
|
|||
| try { | |||
| execSync(`npx nx@${version ?? defaultVersion} daemon --stop`, { | |||
There was a problem hiding this comment.
Should there be a windowsHide here as well?
There was a problem hiding this comment.
sure, not important tho as it's just the e2e
jaysoo
reviewed
Dec 6, 2024
| @@ -102,7 +102,7 @@ export class NxlsClient { | |||
| } | |||
|
|
|||
| public async refreshWorkspace() { | |||
| window.withProgress( | |||
| await window.withProgress( | |||
There was a problem hiding this comment.
Does this fix the spamming refresh issue?
jaysoo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.