Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intellij): improve finding Nx configuration files #2348

Closed
wants to merge 2 commits into from

Conversation

segrey
Copy link
Contributor

@segrey segrey commented Dec 5, 2024

Use ProjectFileIndex.getInstance(project).iterateContentUnderDirectory as it skips visiting excluded files, and there are many of them under node_modules.
Fixes #2347

Use `ProjectFileIndex.getInstance(project).iterateContentUnderDirectory` as it skips visiting excluded files, and there are many of them under `node_modules`.
Fixes nrwl#2347
@segrey segrey requested a review from MaxKless as a code owner December 5, 2024 17:09
Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!!

@MaxKless MaxKless enabled auto-merge (squash) December 6, 2024 11:29
Copy link

nx-cloud bot commented Dec 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af15fa6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@MaxKless
Copy link
Collaborator

MaxKless commented Dec 9, 2024

Thanks again for the PR! It looks like there's some issue with CI since you were contributing from a fork. I reopened the same PR here and merged it: #2352
Made sure you're credited on the commit :)

@MaxKless MaxKless closed this Dec 9, 2024
auto-merge was automatically disabled December 9, 2024 13:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntelliJ Nx Console stucks at finding configuration files
2 participants