Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nxls): use native watcher right away when daemon dies during watch process #2351

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Dec 6, 2024

Before, the following happened:

  • User runs npx nx daemon --stop
  • Daemon stops
  • user checks with npx nx daemon
  • Daemon is running because nx console restarted it for the watcher in the background

Now we instantly transition to using the native watcher (which is what the daemon uses under the hood itself) if the daemon dies. After a change, the daemon is used again. We could think about changing this as well.

Copy link

nx-cloud bot commented Dec 6, 2024

@MaxKless MaxKless merged commit ab5537c into master Dec 9, 2024
5 checks passed
@MaxKless MaxKless deleted the watcher-restart-without-daemon branch December 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants