Dont swallow error

ntex-rs · Nov 4, 2024 · e8aa08e · e8aa08e
1 parent ce1bf97
commit e8aa08e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/ntex/CHANGES.md b/ntex/CHANGES.md
@@ -4,6 +4,8 @@
 
 * Use updated Service trait
 
+* Don't swallow error when calling panic for read_response_json #443
+
 ## [2.7.0] - 2024-10-16
 
 * Better handling for h2 remote payload

diff --git a/ntex/src/web/scope.rs b/ntex/src/web/scope.rs
@@ -5,7 +5,7 @@ use crate::router::{IntoPattern, ResourceDef, Router};
 use crate::service::boxed::{self, BoxService, BoxServiceFactory};
 use crate::service::{chain_factory, dev::ServiceChainFactory, IntoServiceFactory};
 use crate::service::{Identity, Middleware, Service, ServiceCtx, ServiceFactory};
-use crate::util::{join, Extensions};
+use crate::util::{join, select, Extensions};
 
 use super::app::Filter;
 use super::config::ServiceConfig;

diff --git a/ntex/src/web/test.rs b/ntex/src/web/test.rs
@@ -244,8 +244,9 @@ where
 {
     let body = read_response::<S>(app, req).await;
 
-    serde_json::from_slice(&body)
-        .unwrap_or_else(|_| panic!("read_response_json failed during deserialization"))
+    serde_json::from_slice(&body).unwrap_or_else(|e| {
+        panic!("read_response_json failed during deserialization, {:?}", e)
+    })
 }
 
 /// Helper method for extractors testing