Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running tests on 3.12 #200

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Start running tests on 3.12 #200

merged 8 commits into from
Sep 11, 2023

Conversation

MatthieuDartiailh
Copy link
Member

No description provided.

@MatthieuDartiailh MatthieuDartiailh self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #200 (dc1cc41) into main (761a528) will increase coverage by 7.61%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   89.22%   96.84%   +7.61%     
==========================================
  Files          60       24      -36     
  Lines        5580     1109    -4471     
  Branches      359      195     -164     
==========================================
- Hits         4979     1074    -3905     
+ Misses        582       16     -566     
  Partials       19       19              

@MatthieuDartiailh
Copy link
Member Author

After investigating locally it appears that the segfault on exit are linked to cleaning up C++ namespaces containing Python object late in the interpreter shutdown process. The proper workaround is likely to store such variables in a module state (as should be done for a bunch of other global variables).

This may require to drop 3.8 and to do some funny dance on 3.9 and 3.10 since we cannot get a module state in a slot in those versions.

@MatthieuDartiailh MatthieuDartiailh merged commit 8daeb0b into main Sep 11, 2023
22 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the 3.12-fixes branch September 11, 2023 16:59
@MatthieuDartiailh
Copy link
Member Author

I found a workaround for the segfault but we should move to using module states still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant