-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start running tests on 3.12 #200
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 89.22% 96.84% +7.61%
==========================================
Files 60 24 -36
Lines 5580 1109 -4471
Branches 359 195 -164
==========================================
- Hits 4979 1074 -3905
+ Misses 582 16 -566
Partials 19 19 |
After investigating locally it appears that the segfault on exit are linked to cleaning up C++ namespaces containing Python object late in the interpreter shutdown process. The proper workaround is likely to store such variables in a module state (as should be done for a bunch of other global variables). This may require to drop 3.8 and to do some funny dance on 3.9 and 3.10 since we cannot get a module state in a slot in those versions. |
I found a workaround for the segfault but we should move to using module states still. |
No description provided.