Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyPy 3.10 wheels #182

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add PyPy 3.10 wheels #182

merged 2 commits into from
Aug 21, 2024

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Aug 17, 2024

Also, avoid setuptools 72.2.0 on PyPy, because it is broken due to pypa/distutils#283.

@QuLogic QuLogic changed the title Pypy310 Add PyPy 3.10 wheels Aug 17, 2024
@QuLogic
Copy link
Contributor Author

QuLogic commented Aug 17, 2024

Here are the successful wheel builds on all systems: https://github.com/QuLogic/kiwi/actions/runs/10428152508

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Aug 17, 2024
@QuLogic
ci: Avoid setuptools 72.2.0 when installing kiwi on PyPy
752aa98 
Due to https://github.com/pypa/setuptools/issues/4571, kiwisolver fails
to build on PyPy. Until kiwisolver has PyPy 3.10 wheels
(nucleic/kiwi#182), we should avoid the buggy
setuptools.
This was referenced Aug 17, 2024
Merged
Merged
@QuLogic
Copy link
Contributor Author

QuLogic commented Aug 17, 2024

On a side note, I'm not sure if you want to keep supporting Intel macOS, but I think macos-latest is macos-14, meaning only builds for ARM are done now (and I think, at the time of the previous wheel, only Intel wheels were built.)

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Aug 17, 2024
@QuLogic
ci: Avoid setuptools 72.2.0 when installing kiwi on PyPy
a031573 
Due to https://github.com/pypa/setuptools/issues/4571, kiwisolver fails
to build on PyPy. Until kiwisolver has PyPy 3.10 wheels
(nucleic/kiwi#182), we should avoid the buggy
setuptools.
@MatthieuDartiailh
Copy link
Member

Thanks. I do not follow Pypy release so I missed this. Regarding macos I see x86_64 in the log you linked to, so I am reticent to remove them. What does matplotlib do ?

@MatthieuDartiailh MatthieuDartiailh merged commit e7f7b86 into nucleic:main Aug 21, 2024
3 of 22 checks passed
@QuLogic
Copy link
Contributor Author

QuLogic commented Aug 21, 2024

Regarding macos I see x86_64 in the log you linked to, so I am reticent to remove them.

Ah, I was basing that on how I had read the config, but they are both being built, so never mind my original comment.

What does matplotlib do ?

We build both architectures, but stopped doing universal2 builds.

@QuLogic QuLogic deleted the pypy310 branch August 21, 2024 20:24
@MatthieuDartiailh MatthieuDartiailh mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @MatthieuDartiailh