Oz upgrade #160
Oz upgrade #160
Conversation
vzotova
requested review from
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
Tracking here: #164 |
| _minimumAuthorization: 40000000000000000000000 | ||
| - TransparentUpgradeableProxy: | ||
| _logic: $TapirTACoChildApplication | ||
| admin_: $ProxyAdmin |
There was a problem hiding this comment.
it looks like the function signature of TransparentUpgradeableProxy changed in v5.0.0.
constructor(address _logic, address initialOwner, bytes memory _data) payable ERC1967Proxy(_logic, _data) {
scripts/tapir/deploy_root.py
Outdated
|
|
||
| reward_token = deployer.deploy(project.TapirStakingToken) | ||
|
|
||
| mock_threshold_staking = deployer.deploy(project.TestnetThresholdStaking) | ||
|
|
||
| proxy_admin = deployer.deploy(OZ_DEPENDENCY.ProxyAdmin) | ||
| proxy_admin = deployer.deploy(OZ_DEPENDENCY.ProxyAdmin, deployer) |
There was a problem hiding this comment.
The new version of TransparentUpgradeableProxy deploys a default ProxyAdmin so this line will need to be removed. I can address this in vzotova#2
There was a problem hiding this comment.
I suppose we would want to reuse proxy admin between taco child and coordinator, is this possible with the new changes?
There was a problem hiding this comment.
That does not appear to be possible (or necessary) anymore: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/932fddf69a699a9a80fd2396fd1a2ab91cdda123/contracts/proxy/transparent/TransparentUpgradeableProxy.sol#L78
|
This PR will affect
|
Type of PR:
Required reviews:
What this does:
Upgrades OpenZeppelin library to 5.0.0
Issues fixed/closed:
Fixes #159
Why it's needed:
It will be hard to upgrade to 5.x.x version after mainnet
Notes for reviewers:
Based on #145