[EPIC] New fee model architecture #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzotova
changed the title
vzotova
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
derekpierre,
manumonti and
piotr-roslaniec
derekpierre
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Looks like we will need some nucypher updates to accommodate the new architecture. Filed nucypher/nucypher#3514.
contracts/contracts/coordination/subscription/BqETHSubscription.sol
Outdated
Show resolved
Hide resolved
vzotova
force-pushed
the
epic-subscription
branch
from
8e7bb18
to
3886874
Compare
7 tasks
wip: change of plans was a mistakerino
Co-authored-by: James Campbell <james.campbell@tanti.org.uk> Co-authored-by: derekpierre <derek.pierre@gmail.com> Co-authored-by: KPrasch <kieran@nucypher.com>
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
derekpierre
force-pushed
the
epic-subscription
branch
from
0dc8055
to
05b960e
Compare
|
Just rebased this EPIC. Given the size of this PR - we should try to merge this soon. That being said, we should not merge it until v7.4.0 is released since merging it will cause |
KPrasch
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Changes fee model, now it's separate contract that must be approved in coordinator.
Implements subscription for BqETH
Issues fixed/closed:
PRs:
ManagedAllowList#255BetaProgramInitiatorregistry entries #298Why it's needed:
Notes for reviewers:
This PR is ready for tests and integration with nucypher repo, ManagedAllowList needs touch up in some of following PRs