Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo previous change regarding how receipts were obtained #310

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Aug 20, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Undo fd87a11 which applied to ape 0.8.8 but is not applicable for 0.7.x which is the current version of ape used in dependencies, and what we currently use. Revert for now since it is causing issues with deployment scripts when writing to the registry, since the receipt cannot be found.

In the (near?) future, we will relock dependencies to rely on a 0.8.x version of ape, and then the original change may be applicable again.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

…es to ape 0.8.8 but not to ape 0.7.x which we currently use.
@theref
Copy link
Contributor

theref commented Aug 20, 2024

this will be undone in #308 if we don't want another PR 479b2fb

@derekpierre
Copy link
Member Author

derekpierre commented Aug 20, 2024

this will be undone in #308 if we don't want another PR 479b2fb

@vzotova has a Coordinator update to do on lynx, which we are hoping to do tomorrow, so we need this change in main.

I expect this PR will be merged first, and then you can just rebase #308 over main and resolve the conflict.

@theref theref merged commit 9e115b6 into nucypher:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants