Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ape 0.8 #316

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Ape 0.8 #316

merged 6 commits into from
Aug 23, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Aug 22, 2024 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

  • Relocks dependencies
  • Upgrade to latest version of ape 0.8.x and updates relevant ape plugins

Closes #315

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre derekpierre changed the title [WIP] Ape 0.8 Ape 0.8 Aug 22, 2024
@derekpierre derekpierre self-assigned this Aug 22, 2024
@derekpierre derekpierre mentioned this pull request Aug 22, 2024
Merged
7 tasks
@derekpierre derekpierre marked this pull request as ready for review August 22, 2024 23:57
manumonti
manumonti approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 🙌

cygnusv
cygnusv approved these changes Aug 23, 2024
View reviewed changes
ape-config.yaml
@@ -27,17 +27,10 @@ dependencies:
solidity:
version: 0.8.23
evm_version: paris
import_remapping:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

contracts/test/proxy/Destroyable.sol
/**
* @dev Contract that could be destroyed by selfdestruct
*/
contract Destroyable is Upgradeable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remember this, at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it existed 😅 .

A test failed after the update to ape, and I checked with @vzotova, who indicated that it was never used.

@derekpierre derekpierre merged commit 96f24de into nucypher:main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cygnusv cygnusv cygnusv approved these changes

@manumonti manumonti manumonti approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@theref theref Awaiting requested review from theref

@vzotova vzotova Awaiting requested review from vzotova

Assignees

@derekpierre derekpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ape dependencies to > 0.8
3 participants
@derekpierre @cygnusv @manumonti