Working contract verification script to verify individual contracts post-deployment #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
NOTE
ape
For
ape-etherscan
, I implemented a flimsy workaround for now, derekpierre/ape-etherscan@f68365a, related to what I read here, https://mirror.xyz/n00b21337.eth/4HDSO5tlP3-_CAKUgT5QgQ4iIJZ7RH46zucebjycoN8 (it's pretty flimsy! 😟 ) , and added a github dependency to my fork. Once theape
folks provide a proper fix, we can switch back to their released version.verify
script to verify contracts post-deployment. If the deployed contract was proxied, the underlying implementation contract is verified.ape-solidity
0.8.4 and my workaround for theape-etherscan
issue (explained below).Example usage:
tapir
and contract info included intapir.json
contract registrymainnet
and contract info not included inmainnet.json
but rather in a separate registry fileIssues fixed/closed:
Why it's needed:
Notes for reviewers:
Are we ok having this github dependency for modified
ape-etherscan
inmain
? The upside is that if this PR is merged then anyone can do post-deployment contract verification.-> Filed #331 to replace the dependency once the fix is available
I still wouldn't integrate verification with deployment just yet; better to continue to verify contracts separately, post-deployment since the workaround is so flimsy.