-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Porter README and diagrams #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #40 +/- ##
============================================
Coverage 87.72% 87.72%
============================================
Files 18 18
Lines 709 709
============================================
Hits 622 622
Misses 87 87
|
theref
reviewed
Oct 12, 2023
theref
reviewed
Oct 12, 2023
derekpierre
added a commit
to derekpierre/nucypher-porter
that referenced
this pull request
Oct 12, 2023
theref
approved these changes
Oct 12, 2023
piotr-roslaniec
approved these changes
Oct 16, 2023
manumonti
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤘
derekpierre
force-pushed
the
update-readme
branch
from
October 16, 2023 12:31
c0f984f
to
af54c30
Compare
derekpierre
added a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
/cbd_decrypt
endpoint.Questions for reviewers:
/cbd_decrypt
endpoint (Change/cbd_decrypt
endpoint name to something TACo related #42 )/retrieve_cfrags
to a PRE specific section in the README (this was PRE reencrypt)./get_ursulas
remains at a high-level. Any concerns/thoughts about that?nucypher
7.0.0 release (Bump Porter version #41 ).Issues fixed/closed:
Why it's needed:
Notes for reviewers: